Code Review Workflow

Workflow for reviewing tickets (QC process) and addressing review feedback.

Prerequisites

CLI installed and authenticated
Access to JIRA/GitHub workspace

For Reviewers: QC Process

# 1. Start QC
wseng qc start LAMBDA-12345

# 2. Review code, test functionality, watch demo video

# 3. Generate automated review
wseng review-work

# 4. Fetch PR comments
wseng fetch-pr-review

# 5. Make decision
wseng qc pass          # ✅ Pass
wseng qc soft-push     # ❌ Send back for changes
wseng qc stop          # ⏸️ Stop reviewing (can't complete)

QC Commands

Start QC:

wseng qc start LAMBDA-12345

Assigns you as reviewer, transitions ticket to "In QC", checks out branch.

Override assignment:

wseng qc start LAMBDA-12345 --force-review

Pass:

wseng qc pass

Transitions ticket to "Delivered".

Send back:

wseng qc soft-push

Transitions to "Ready for Work". Leave clear PR comments explaining what needs to change.

Stop review:

wseng qc stop

Transitions back to "Ready for QC", unassigns you.

For Implementers: Addressing Feedback

# 1. Fetch review comments
wseng fetch-pr-review

# 2. Auto-fix unresolved comments (optional)
wseng fetch-pr-review --implement

# 3. Make manual fixes

# 4. Commit changes
wseng commit --type fix

# 5. Resubmit for review

Automated Checks

When ticket is pushed to review, these run automatically via JIRA/GitHub webhooks:

wseng verify-acceptance-video - Validates demo video
wseng review-work - Automated code review
wseng ws infer-breakdown - Calculates story points

Results posted as PR comments.

Common Pitfalls

❌ Bad: Soft-pushing without clear feedback

wseng qc soft-push
# No PR comments explaining issues

Solution: Always leave detailed PR comments before soft-pushing. Implementer needs to know what's wrong, why, and how to fix it.

❌ Bad: Not watching demo video

Skipping the demo video and only reviewing code can miss integration issues and misunderstandings that aren't visible in code.

Solution: Always watch the demo. Verify ALL acceptance criteria are demonstrated.